Skip to content

[skip changelog] Fix failing legacy testing #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2021
Merged

[skip changelog] Fix failing legacy testing #1167

merged 1 commit into from
Feb 4, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes tests.

  • What is the current behavior?

Some legacy tests are failing, this is probably caused by a parallelization issues.

  • What is the new behavior?

They should run smoothly and with no issues now.

Nope.

  • Other information:

None.

See how to contribute

@silvanocerza silvanocerza requested a review from cmaglie February 4, 2021 10:02
@silvanocerza silvanocerza self-assigned this Feb 4, 2021
@silvanocerza silvanocerza merged commit a9b0c9d into master Feb 4, 2021
@silvanocerza silvanocerza deleted the scerza/fix-legacy-test branch February 4, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees

@silvanocerza silvanocerza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @cmaglie